I'm still reading through the opinion, but it's a fine piece of work -- detailed and well organized. Judge O'Scannlain did an excellent historical overveiw.
Of course gun control advocates won't give up. Why would any of us expect them to? We didn't give up when we suffered setbacks. This tension between gun control and gun rights will continue indefinitely.
But now with this ruling together with an number of others like Judge Posner's opinion in Moore we're developing a strong pro-Second Amendment judicial literature. The reasoning and reviews of past decisions, past commentary and the historical context of the Second Amendment are helping to build the foundation for future arguments in future cases.
"It is long been a principle of ours that one is no more armed because he has possession of a firearm than he is a musician because he owns a piano. There is no point in having a gun if you are not capable of using it skillfully." -- Jeff Cooper