You're correct and not missing anything. Frank quoted federal law. NY's definition of "firearm" does not change the federal definition.
ETA: Bosshoff, be sure to consult your state laws, as well.
I'm a lawyer, but I'm not your lawyer. If you need some honest-to-goodness legal advice, go buy some.