There have been numerous threads over the past year as to the career potential of gunsmithing. In summary:
Find a mentor who knows what he is doing
Treat it like a business,
Treat your customers well
Don't expect to make any money for the first five years.
Don't work for nothing.